auto-launch support [Electron] #4012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
settings are sorta generic, probably reusable for proxy settings Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
t3chguy
changed the title
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
electron/electron#9621 Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
…-web into t3chguy/electron_settings
(which has hit me once) Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
ara4n
reviewed
May 30, 2017
| @@ -45,47 +46,6 @@ const INITIAL_UPDATE_DELAY_MS = 30 * 1000; | |||
| let mainWindow = null; | |||
| let appQuitting = false; | |||
|
|
|||
| function safeOpenURL(target) { | |||
There was a problem hiding this comment.
um, why is this all being deleted?
|
lgtm other one confusion |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
settings are sorta generic, probably reusable for proxy settings
cross-platform start with system log in support
depends on matrix-org/matrix-react-sdk/pull/920
NEEDS MORE TESTINGNEEDS REVIEWedit
does not start hidden on Linux, do not merge until this is addressed.edit2: workaround fitted and upstream bug reported electron/electron/issues/9621