Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add moar context menus [Electron] #4021

Merged
merged 2 commits into from
May 25, 2017
Merged

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented May 25, 2017

split all webContents.on's into the new file, keeping main cleaner
add handlers for editable fields, with Cut Copy Paste Undo Redo etc
add Copy Image feature to all images, working on not only the download
buttons now

fixes #3156

screenshot 87

Signed-off-by: Michael Telatynski 7t3chguy@gmail.com

add handlers for editable fields, with Cut Copy Paste Undo Redo etc
add Copy Image feature to all images, working on not only the download
buttons now

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have already fed this back on #riot-dev, but ftr it's better to separate things like this into one commit that moves things to the new file and then another that adds to the new file.

@dbkr dbkr merged commit 5ccab39 into develop May 25, 2017
@t3chguy
Copy link
Member Author

t3chguy commented May 25, 2017

@dbkr will remember for next time, sorry

@t3chguy t3chguy deleted the t3chguy/electron_context_menus branch October 29, 2017 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

right-click doesn't work on electron lightbox zoomed image
2 participants