Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sorting of networks within a protocol based on name #4054

Merged
merged 1 commit into from
Oct 14, 2017
Merged

Sorting of networks within a protocol based on name #4054

merged 1 commit into from
Oct 14, 2017

Conversation

ollieh
Copy link
Contributor

@ollieh ollieh commented May 27, 2017

#3771

Now it looks like this:
screenshot_2017-05-27_17-27-39

@turt2live
Copy link
Member

iirc "matrix.org" is intended to be the parent heading, then all the things with icons are subpoints of matrix.org, just badly shown as such.

@ollieh
Copy link
Contributor Author

ollieh commented May 27, 2017

Will there ever be multiple headings, or can I just stick it at the top?

@turt2live
Copy link
Member

It's possible for custom-homeserver folk:
image

(and for others who define their settings correctly... somehow).

@ollieh
Copy link
Contributor Author

ollieh commented May 27, 2017

Ooh, that makes things rather trickier.

@ollieh
Copy link
Contributor Author

ollieh commented May 27, 2017

Changed it to just sort between headings, although it feels a bit complicated. I guess it could be simplified if it did this while it was adding them, but I wanted to keep the sorting logic separated in case I changed the behaviour.

@ollieh
Sorting of networks within a protocol based on name
16357a9 
Signed-off-by: Oliver Hunt <oliver@hunt.bz>
@ollieh
Copy link
Contributor Author

ollieh commented May 27, 2017 •
edited
Loading

Figured out how the list was being constructed and put the sorting logic in there, much neater!
screenshot_2017-05-27_19-12-25

@ollieh ollieh changed the title Sorting of networks based on icon and text Sorting of networks within a protocol based on name May 27, 2017
@t3chguy
Copy link
Member

t3chguy commented May 27, 2017

looks much better than the initial pr diff

@Half-Shot Half-Shot mentioned this pull request Jun 15, 2017
Closed
@lukebarnard1 lukebarnard1 removed their assignment Jun 19, 2017
@lukebarnard1
Copy link
Contributor

Removing my assignment for now as I don't actually know if we want Gitter all the way down there. @ara4n's input would be appreciated.

@uhoreg uhoreg mentioned this pull request Jun 30, 2017
Closed
@ara4n
Copy link
Member

ara4n commented Oct 14, 2017

sorry for missing this months ago - if you need my input please assign it to me... the alphabetised list looks good to me.

@ara4n ara4n merged commit 6f81960 into element-hq:develop Oct 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ollieh @turt2live @t3chguy @lukebarnard1 @ara4n