Translate src/vector #4119
Merged
Translate src/vector #4119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 31, 2017
|
Integration tests failed when GH was down: |
t3chguy
reviewed
May 31, 2017
| @@ -19,6 +19,7 @@ limitations under the License. | |||
|
|
|||
| import VectorBasePlatform from './VectorBasePlatform'; | |||
| import dis from 'matrix-react-sdk/lib/dispatcher'; | |||
| import _t from 'matrix-react-sdk/lib/languageHandler'; | |||
There was a problem hiding this comment.
Should it not be import { _t } from 'matrix-react-sdk/lib/languageHandler'; ?
There was a problem hiding this comment.
Yep, typically I had only tested this on WebPlatform which was the only one to import correctly. Thanks.
t3chguy
reviewed
May 31, 2017
| @@ -18,6 +18,8 @@ limitations under the License. | |||
| */ | |||
|
|
|||
| import BasePlatform from 'matrix-react-sdk/lib/BasePlatform'; | |||
| import _t from 'matrix-react-sdk/lib/languageHandler'; | |||
There was a problem hiding this comment.
Yep, typically I had only tested this on WebPlatform which was the only one to import correctly. Thanks.
|
Apart from Q, LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including
src/vector/platform.