Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempts to deflakify the joining test #4313

Merged
merged 4 commits into from
Jun 15, 2017
Merged

Attempts to deflakify the joining test #4313

merged 4 commits into from
Jun 15, 2017

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Jun 14, 2017

  • see the commits for details

@richvdh
Copy link
Member Author

richvdh commented Jun 14, 2017

hum

@richvdh richvdh force-pushed the rav/deflakify_joining_test branch from 61de80b to 9a5d170 Compare June 14, 2017 15:55
@richvdh
Improve logging in mock-request
27d5704 
Try to make it a bit more obvious what's been going on in mock-request: add
timestamps to lines, and an identifier so that where we have two flushes in
parallel, we can see what's what.
@richvdh richvdh force-pushed the rav/deflakify_joining_test branch 4 times, most recently from 28bcb2c to 3c4d322 Compare June 14, 2017 21:58
@richvdh
Attempts to deflakify the joining test
6f2eee1 
Treat the waitTime passed into `flush` as a timeout rather than a
time-between-loops, so that we can pass in bigger times and not slow the tests
down too much.

Bump the timeout when waiting for /publicRooms and /initialSync in the joining
test.
@richvdh richvdh force-pushed the rav/deflakify_joining_test branch from 3c4d322 to 6f2eee1 Compare June 14, 2017 21:58
@lukebarnard1
Copy link
Contributor

So it looks like the test failed once.. possible indication of flakiness?

@lukebarnard1 lukebarnard1 assigned richvdh and unassigned lukebarnard1 Jun 15, 2017
@richvdh richvdh assigned lukebarnard1 and unassigned richvdh Jun 15, 2017
@richvdh richvdh merged commit 584e4c0 into develop Jun 15, 2017
@richvdh richvdh deleted the rav/deflakify_joining_test branch June 20, 2017 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukebarnard1 lukebarnard1 lukebarnard1 approved these changes

Assignees

@lukebarnard1 lukebarnard1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richvdh @lukebarnard1