Add some style improvements to autocompletions #4456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lukebarnard1
commented
Jun 28, 2017
lukebarnard1
commented
- Fix Wrap/ellipsize autocomplete text correctly #2230 by adding text-overflow: ellipsis to pill spans
- Add padding to pills
- Make sure to only apply horizontal margin of pill children at one level of the DOM tree
- Fix #2230 by adding text-overflow: ellipsis to pill spans - Add padding to pills - Make sure to only apply horizontal margin of pill children at one level of the DOM tree
|
Whoops, sorry @aviraldg! I butter-fingered there. |
dbkr
reviewed
Jun 28, 2017
| display: flex; | ||
| user-select: none; | ||
| cursor: pointer; | ||
| align-items: center; | ||
| color: $primary-fg-color; | ||
| } | ||
|
|
||
| .mx_Autocomplete_Completion_pill * { | ||
| .mx_Autocomplete_Completion_pill > * { |
There was a problem hiding this comment.
Hmm, I slightly question whether being in an autocomplete pill implies things will want this CSS, or whether it would be better to put this on the children directly, but if this works then fine.
There was a problem hiding this comment.
I think it was the original intention. I think it's only worth changing if there's a child that doesn't want a margin, which for the time being there isn't 😇
|
the tests are failing for some totally unrelated reason... I'll try rerunning them |
|
There seems to be a persistent |
|
I'm merging this because it can't have broken the tests 😇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.