Remove userId property on RightPanel #4775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because we shouldn't have a dispatch AND have a property that do vaguely similar things. Ideally, the dispatch would send a userId and RP would do async work to get the member/avatar/displayname.
dbkr
reviewed
Aug 10, 2017
| @@ -31,7 +31,6 @@ module.exports = React.createClass({ | |||
| displayName: 'RightPanel', | |||
|
|
|||
| propTypes: { | |||
| userId: React.PropTypes.string, // if showing an orphaned MemberInfo page, this is set | |||
There was a problem hiding this comment.
Presumably the long term plan here to do the same for roomId, in which case we should add a comment or else someone will change it back to using props again.
There was a problem hiding this comment.
I don't think so given that the file panel and member list take the room as a prop. I suppose the RightPanel could listen to view_room instead of accepting roomID as a prop?
There was a problem hiding this comment.
Yeah, I'm assuming we'd be consistent and eventually move to using dispatches everywhere.
There was a problem hiding this comment.
oh I mean it should really listen to the RVS like everything else. I shall comment
dbkr
approved these changes
Aug 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because we shouldn't have a dispatch AND have a property that do vaguely similar things. Ideally, the dispatch would send a userId and RP would do async work to get the member/avatar/displayname.