Bring back dark theme code block border #5037
Conversation
| @@ -131,6 +131,9 @@ $progressbar-color: #000; | |||
| } | |||
|
|
|||
| // markdown overrides: | |||
| .mx_EventTile_content .markdown-body pre:hover { | |||
| border-color: #808080 !important; // inverted due to rules below | |||
There was a problem hiding this comment.
should this not be some SCSS Var?
There was a problem hiding this comment.
Possibly. I'm not sure what the guidelines are for this, as it's an override from the base, but intentionally doesn't affect the light theme.
There was a problem hiding this comment.
this is a bit of a grey area (hah) - in this instance given all the other stuff nearby are hardcoded for now i'm happy to let it slip.
|
lgtm, thanks! |
|
that said, i'm a bit worried that we've ended up with |
|
/me makes mental note to open a maintenance PR in that respect |
|
(since when did GFM automatically put swatches next to hex colors?! |
This fixes #5013 and #4416 by only showing the border when the code block is hovered, and that the border is actually visible. The !important is needed to override the default border behaviour.