Leverages ES6 in Notifications #5453
Conversation
| @@ -15,33 +15,33 @@ limitations under the License. | |||
| */ | |||
|
|
|||
| 'use strict'; | |||
| var React = require('react'); | |||
| const React = require('react'); | |||
There was a problem hiding this comment.
when updating to ES6, the correct way to fix these imports is actually to turn them into:
import React from 'react';
This technically works, but is very much not best practice.
|
this is great - thanks! the only sticking point is to change the imports/requires to ES6-style for consistency with the rest of the update, but otherwise looks good to me. (Interestingly, it looks like we have a blind spot when doing |
|
Sounds good to me! Changes have been made. ES6 is implicitly in strict mode, so I also removed |
|
awesome! lgtm, thanks again :) |
|
actually, there was one other catch: the PR is against master rather than develop, but I have changed the base in gihub successfully. technically you should also formally sign off the PR (see the DCO in contributing.rst) to confirm you are ok with the project licensing terms. going to merge anyway if you can put a DCO signoff in the comments here :) |
|
Whoops, I'm sorry about that! I had read to do that, then it slipped me. I look forward to contributing more to such a great project! :) Signed-off-by: Vicky Koblinski vickykoblinski@gmail.com |
This task was mostly to familiarize myself with a piece of Riot.