Add toggle to alter visibility of room-group association #5497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
dbkr
requested changes
Nov 2, 2017
| </div> | ||
| ); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Any reason this isn't in react-sdk?
Edit: in fact, you've referenced it in react-sdk so it should definitely be in react-sdk
There was a problem hiding this comment.
Probably because I put it where Spinner was. Do we care at this point, given we're going to merge them?
There was a problem hiding this comment.
FTW, the IRL answer was no.
|
And another test flake |
dbkr
approved these changes
Nov 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For matrix-org/matrix-react-sdk#1566