Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS for improving group creation UX, namely setting long description #5535

Merged
merged 2 commits into from
Nov 7, 2017

Conversation

lukebarnard1
Copy link
Contributor

@@ -304,6 +304,18 @@ limitations under the License.
}

.mx_GroupView_groupDesc textarea {
width: 50%;
width: 100%;
max-width: 100%;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't be needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just stops the user being silly and dragging the textarea wider than it should go. But it still allows for them to adjust its vertical height.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"it's textareas being weird" i think is the answer then :D


.mx_GroupView_groupDesc_placeholder {
background-color: $group-my-groups-placeholder-bg;
color: $group-my-groups-placeholder-fg;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm surprised this needs a custom colour? shouldn't one of the existing generic theme colours fit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might have been one that already existed but I guess its name felt to specific for me to reuse it somewhere else... although I have contradicted myself here by using a $group-my-groups-* variable in GroupView.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e.g. the "preview-bg-color" or whatever it's called. if it feels icky to reuse the same constant for this component, one could always rename it as "info-plinth-bg-color" or something

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

info-plinth-bg-color +1 !

@ara4n
Copy link
Member

ara4n commented Nov 6, 2017

lgtm mod comments

@ara4n ara4n merged commit 9ff1fe8 into develop Nov 7, 2017
@t3chguy t3chguy deleted the luke/groups-new-group-settings branch May 12, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants