Status.im theme #5578
Status.im theme #5578
Conversation
> > as it's much nicer in the CSS to wrap the LoginBox as needed rather than have separate header & footer divs floating above and below it which need to be correctly vertically centered
| "disable_custom_urls": false, | ||
| "disable_guests": false, | ||
| "disable_login_language_selector": false, | ||
| "disable_3pid_login": false, |
There was a problem hiding this comment.
Note to self: These should be pulled into GranularSettings when it lands
There was a problem hiding this comment.
decided to not make these granular - they are app-level anyways and affect people who aren't logged in, so granularity isn't feasible.
| - e.g. if we replace `Login.js` with `StatusLogin.js`, then we should similarly be able to replace `_Login.scss` with `_StatusLogin.scss`. | ||
|
|
||
| random thoughts; | ||
| - should we be able to change the entire skin at runtime (more like wordpress) - to the extent of replacing entire components? |
There was a problem hiding this comment.
What about color pickers for now? Not like just tint but changing different parts of the Design without needing to change the code
src/vector/index.js
Outdated
| @@ -250,16 +251,20 @@ async function loadApp() { | |||
|
|
|||
| if (!preventRedirect) { | |||
| if (/iPad|iPhone|iPod/.test(navigator.userAgent) && !window.MSStream) { | |||
| if (confirm(_t("Riot is not supported on mobile web. Install the app?"))) { | |||
| window.location = "https://status.im/join-riot.html"; | |||
There was a problem hiding this comment.
Won't that cause problems for selfhosted Riots?
There was a problem hiding this comment.
thanks for noticing this.
Yes, please don't hijack people
There was a problem hiding this comment.
heh, looks like this crept in whilst my back was turned. of course it’s not meant to be there; will turn it into a config options. thanks!
There was a problem hiding this comment.
@ara4n Note a few lines below this is the same line again ;)
|
@dbkr LGTMed this at high level OOB, so merging. It'll probably break everything, but y'all should be testing /staging for 0.13.0-rc2 anyway, and I want to give @turt2live a chance to merge it to his GranularSettings tonight (and then merge that too). |
Land the long-lived Status.im theme branch. Obviously this should ideally be split up into PRs, but unfortunately life is too short atm :/
Twinned with matrix-org/matrix-react-sdk#1605
Stuff to be aware of here: