Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use badge count format for member count in RightPanel #5657

Merged
merged 1 commit into from
Nov 20, 2017
Merged

Use badge count format for member count in RightPanel #5657

merged 1 commit into from
Nov 20, 2017

Conversation

lukebarnard1
Copy link
Contributor

@lukebarnard1 lukebarnard1 commented Nov 20, 2017 •
edited
Loading

to avoid cosmetic disasters with >9999 members in a room, e.g. HQ:
screen shot 2017-11-20 at 13 11 41

@lukebarnard1
Use badge count format for member count in RightPanel
7cb59bd 
(to avoid cosmetic disasters with >9999 members in a room, e.g. HQ)
t3chguy
t3chguy approved these changes Nov 20, 2017
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lukebarnard1
Copy link
Contributor Author

Thanks, @t3chguy :D

@lukebarnard1 lukebarnard1 merged commit f2e6659 into develop Nov 20, 2017
@t3chguy t3chguy deleted the luke/fix-member-count-format branch May 12, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukebarnard1 @t3chguy @dbkr