Clarify that HTTPS is not just needed for VoIP #6146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…but for basic security.
|
The pr should go against the develop branch. |
t3chguy
reviewed
Mar 4, 2018
MTRNord
reviewed
Mar 5, 2018
t3chguy
reviewed
Mar 21, 2018
|
Ping @rugk still have a comment not responded to. |
In addition to fixes from review, also add link to official source with more information.
|
Sorry, seems I've missed the notifications. 😄 Finally, improved/fixed. |
|
@rugk If you have time to apply the suggestion above or mark the PR so that maintainers can edit and do so, then I believe we can press the merge button after that. 😁 |
Co-Authored-By: Travis Ralston <travpc@gmail.com>
|
Done. FYI "Allow edits from maintainers." had already been aliowed/selected. |
|
for some reason it was blocking me from doing both in and out of github :( Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…but for basic security.