Prevent referrers from being sent #6155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eras
added a commit
to eras/matrix-react-sdk
that referenced
this pull request
Oct 20, 2019
An alternative fix to element-hq/element-web#6147 which for some reason the PR element-hq/element-web#6155 is not yet merged. The key difference is that the riot-web PR element-hq/element-web#6155 uses HTML meta header for noreferrer, while this one adds the rel-attribute to include the noreferrer keyword in both user-created links as well as links converted from incoming events. I guess it's up to the maintainers then to pick and choose, but please do ;).
|
lgtm - thanks @rugk, and sorry that we completely missed the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6147