Fix bug where cannot send group invite on GroupMemberInfo phase #6303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by not reusing the same function and invoking separate conditions to decide what the function does but instead using different functions. Also, show the GroupMemberList after inviting a member, otherwise we might end up looking at the member we were already looking at instead of the updated list of members.
lukebarnard1
added a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Mar 12, 2018
because we might be looking at a member when inviting a new member. See element-hq/element-web#6303
dbkr
approved these changes
Mar 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by not reusing the same function and invoking separate conditions
to decide what the function does but instead using different
functions.
Also, show the GroupMemberList after inviting a member, otherwise
we might end up looking at the member we were already looking at
instead of the updated list of members.
Codep matrix-org/matrix-react-sdk#1796
Fixes #6302