Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a simple shouldComponentUpdate for DNDRoomTile #6313

Merged
merged 2 commits into from
Mar 15, 2018
Merged

Implement a simple shouldComponentUpdate for DNDRoomTile #6313

merged 2 commits into from
Mar 15, 2018

Conversation

lukebarnard1
Copy link
Contributor

@lukebarnard1 lukebarnard1 commented Mar 14, 2018 •
edited
Loading

because otherwise beautiful dnd spends a lot of time requesting
animation frames pointlessly.

a continuation of matrix-org/matrix-react-sdk#1801

mitigates #6060

@lukebarnard1
Implement a simple shouldComponentUpdate for DNDRoomTile
04b1678 
because otherwise beautiful dnd spends a lot of time requesting
animation frames pointlessly.
@lukebarnard1 lukebarnard1 mentioned this pull request Mar 14, 2018
Closed
dbkr
dbkr approved these changes Mar 14, 2018
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, although in this case (and probably the other case actually) do you not just want to extend PureComponent?

@lukebarnard1
Copy link
Contributor Author

do you not just want to extend PureComponent?

oh. I've not used it before but sounds like a better plan.

@dbkr dbkr assigned lukebarnard1 and unassigned dbkr Mar 15, 2018
@lukebarnard1 lukebarnard1 assigned dbkr and unassigned lukebarnard1 Mar 15, 2018
@dbkr
Copy link
Member

dbkr commented Mar 15, 2018

re-lgtm

@dbkr dbkr assigned lukebarnard1 and unassigned dbkr Mar 15, 2018
@lukebarnard1 lukebarnard1 merged commit 6dc7592 into develop Mar 15, 2018
@lukebarnard1 lukebarnard1 mentioned this pull request Mar 16, 2018
Closed
@t3chguy t3chguy deleted the luke/perf-room-list-dnd branch May 12, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr dbkr approved these changes

Assignees

@lukebarnard1 lukebarnard1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukebarnard1 @dbkr