Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Render simple counters in room header" details #9154

Merged
merged 3 commits into from
Mar 22, 2019
Merged

"Render simple counters in room header" details #9154

merged 3 commits into from
Mar 22, 2019

Conversation

benparsons
Copy link
Member

No description provided.

@benparsons benparsons requested a review from a team March 13, 2019 17:55
@turt2live turt2live self-requested a review March 13, 2019 19:25
turt2live
turt2live approved these changes Mar 13, 2019
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to link to this from the README, and line wrap it at roughly 120 characters.

I think your build failure is unrelated: it's complaining about a unit test failure which obviously doesn't make sense for this change.

@benparsons benparsons merged commit 5566fd4 into develop Mar 22, 2019
@benparsons benparsons deleted the benp/labs-docs branch March 22, 2019 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benparsons @turt2live