Add support for custom profile directory #9408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
previously requested changes
Apr 9, 2019
There was a problem hiding this comment.
Thanks for the PR! Please take a look at our contributing guidelines (which also apply to this project) for things like signoff.
In addition, some documentation on the new argument in the readme would be handy.
pacien
force-pushed
the
custom-profiledir
branch
from
faefbd7
to
71e088f
Compare
|
@turt2live Sure, the commit has been amended accordingly. |
turt2live
dismissed
their stale review
concerns addressed - sending to the team review queue for code review
jryans
requested changes
Apr 9, 2019
A custom user data directory can now be specified using the "profile-dir" command line argument. Github ref: closes element-hq#6175 Signed-off-by: Pacien TRAN-GIRARD <pacien.trangirard@pacien.net>
pacien
force-pushed
the
custom-profiledir
branch
from
71e088f
to
2c9b51f
Compare
jryans
approved these changes
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A custom user data directory can now be specified using the "profile-dir" command line argument.
This PR solves #6175.