Validate default homeserver config before loading the app #9496
Conversation
|
asking for code review to make sure that the approach is valid. The behaviour may change though |
|
Right, I'm moving forward with the identity server behaviour as proposed - if we want to change it, it isn't terribly difficult but needs some thought. This part of the whole stack is also ready for review by someone. |
turt2live
dismissed
bwindels’s stale review
approving review is for the approach, not the code - dismissing so that github doesn't think this is approved
|
The tests are actually fairly sensitive to these changes, so I'm pulling this out of review until I can fix them. |
Implements the process described here: #9290 (comment) The expectation is that later layers (like the react-sdk) will make use of the `validated_discovery_config` option instead of interpreting the config themselves. We intentionally block the UI from loading here to avoid races between discovery and the app loading.
It's usable as-is, and we can add things to it when we need to (ie: integrations).
turt2live
force-pushed
the
travis/guests/block-ui
branch
from
ed19ec6
to
a5092dc
Compare
Supply a server config to the component and adjust the wait logic to be less of a race. The Login component will noop onPasswordLogin if it is "busy", and it is busy when it requests the login flows.
|
Changing the base to |
|
... also I'm going to press the right buttons |
Reviewer: This is generally best reviewed as the final diff rather than the individual commits. Note that there's a TODO comment in the diff which has the intention of being followed up by a later PR - the PRs for this work item are getting a bit large, so this is being put up for review with a known deficiency.
The TODO comment affects those who happen to use https://riot.im/develop/#/login?hs_url=https://matrix.org instead of the other options. It may also affect people's ability to claim 3pid validations.
See #9290
Fixes #8826
Please review with matrix-org/matrix-react-sdk#2941 (the implementation)
Implements the process described here: #9290 (comment)
The expectation is that later layers (like the react-sdk) will make use of the
validated_discovery_configoption instead of interpreting the config themselves.We intentionally block the UI from loading here to avoid races between discovery and the app loading.
Requires matrix-org/matrix-js-sdk#897Merged.Blocked on clarification regarding identity server behaviour.Going forward with this as-proposed with the intention of verifying that this is the correct behaviour.We strive for not having defaults anymore, however the identity server is optional across the stack. Additionally, there is some concern that the federation is torn on whether or not .well-known should include an identity server:
(sampled from #riot-web, #matrix, and #riot-web-announcements)