Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update installation instructions with new repo #9500

Merged
merged 4 commits into from
Apr 17, 2019

Conversation

axelsimon
Copy link
Contributor

@axelsimon axelsimon commented Apr 16, 2019

Signed-off-by: axel simon <axelsimon at axelsimon.net>

change mentions of https://riot.im/packages to https://packages.riot.im
add instructions to remove old, now-untrusted riot.im signing key
update language and move from 'apt-get` to the simpler `apt`
@jryans jryans requested a review from a team April 16, 2019 12:28
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise looks great, thanks!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
dbkr and others added 2 commits April 16, 2019 17:55
better wording

Co-Authored-By: axelsimon <github@axelsimon.net>
README.md Outdated
Releases are signed by PGP, and can be checked against the public key
at https://riot.im/packages/keys/riot.asc .
Releases are signed using gpg and the OpenPGP standard, and can be checked against the public key located
at https://packages.riot.im/debian/riot.im-archive-keyring.asc .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't exist, did you mean riot-im-archive-keyring.asc ? Also someone is going to have to explain to me the difference between that and https://packages.riot.im/riot-release-key.asc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks.
I really meant https://packages.riot.im/riot-release-key.asc, I'll amend.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given that's also Dave's suggestion, I'm inclined to trust that too :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we've got https://packages.riot.im/riot-release-key.asc for the general package signing and https://packages.riot.im/debian/riot.im-archive-keyring.asc as the key to add to apt's key store, on Debian. Correct?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those sound like the right things to me

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that's right - the signing keys are now separate with one the one in /debian for the debian repo and the release key for signing the web release tarballs.

@dbkr dbkr merged commit 2c0504d into element-hq:develop Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants