Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for defaultCountryCode #9927

Merged
merged 1 commit into from
Jun 1, 2019
Merged

Add docs for defaultCountryCode #9927

merged 1 commit into from
Jun 1, 2019

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Jun 1, 2019 •
edited
Loading

@turt2live turt2live mentioned this pull request Jun 1, 2019
Merged
@turt2live turt2live requested a review from a team June 1, 2019 03:29
@ara4n
Copy link
Member

ara4n commented Jun 1, 2019

lgtm, but shouldn’t we be pulling this from the Accept headers?

@turt2live
Copy link
Member Author

The user's language was a bit unreliable in my testing. Stuff like "en" showing up without a country.

@turt2live turt2live merged commit 29eeb1e into develop Jun 1, 2019
@turt2live turt2live deleted the travis/default-country-code branch June 1, 2019 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turt2live @ara4n