Get and display a user's pushers in settings #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Really this is so (in a subsequent PR) we can show whether a user has an email pusher, but we can basically display the list of pushers for free, so adding this too.
| if (this.state.pushers === undefined) { | ||
| devicesSection = <div className="error">Unable to fetch device list</div> | ||
| } else if (this.state.pushers.length == 0) { | ||
| devicesSection = <div><i>No devices are push notifications</i></div> |
There was a problem hiding this comment.
would prefer to see a CSS class than explicit <i>
|
lgtm otherwise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly groundwork for email notifications check box, but this makes it trivial to list the pushers on a user's account so adding this too because it could be a useful feature.
Requires matrix-org/synapse#716 to work but will just display an error message on older servers.
Requires matrix-org/matrix-js-sdk#125 (already merged).