Wmwragg/modal restyle #1806
Merged
Wmwragg/modal restyle #1806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d a global selector to remove the ugly firefox dotted line highlight
…ttons are styled correctly
|
Can one of the admins verify this patch? |
| @@ -161,8 +167,8 @@ input[type=text]:focus, textarea:focus { | |||
| left: 0; | |||
| width: 100%; | |||
| height: 100%; | |||
| background-color: #000; | |||
| opacity: 0.2; | |||
| background-color: #e9e9e9; | |||
There was a problem hiding this comment.
this looks like it will break lightbox background color? .mx_Dialog_lightbox presumably now needs an explicit color: #000;
There was a problem hiding this comment.
Apologies for that, I thought the .mx_Dialog_background was just for the Dialogs. I fixed it now, and just pushed
|
lgtm other than comment |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restyles the Modal dialog boxes as shown in Zeplin "02_x Chat modal" and closes #1760. There is a linked branch
wmwragg/modal-restyleon thematrix-react-sdkrepo that also needs to be merged.Signed-off-by: William Wragg wm.wragg@gmail.com