Wmwragg/mention state indicator #1823
Conversation
…the same size as it was originally
|
Can one of the admins verify this patch? |
| position: absolute; | ||
| display: block; | ||
| width: 0; | ||
| height: 0; |
There was a problem hiding this comment.
slightly wonky whitespace here - please no \t's!
There was a problem hiding this comment.
Sorry about that, not sure how that crept in, I have my editor set to 4 spaces. Fixed
|
hm, am i missing the matrix-react-sdk half of this one? |
|
There is no matrix-react-sdk part for this, it's purely CSS restyling |
|
No scratch that, I'll dig into why that isn't pushed. |
|
Yeah sorry, I created both branches, as I thought I'd need to make changes for both sides when I did my initial investigation. But turns out I didn't, but I must have still had it in my head when I made the above comment, sorry. So just to be clear, there is no matrix-react-sdk branch for this, it only required CSS restyle work. |
| width: 0; | ||
| height: 0; | ||
| margin-left: 7px; | ||
| border-top: 8px solid #ff0064; |
There was a problem hiding this comment.
this still looks to be \t characters - please can we use 4 spaces everywhere for tabulation?
There was a problem hiding this comment.
This is weird, I'm going to search the code base for tabs, as I'm definitely not putting then in, this code was copied from another section.
|
otherwise lgtm |
|
The linked matrix-sdk-branch, is weird. After further investigation, it is requited, and does exist, but says there are no diffs against develop, so I'm not sure whats going on. I'll get back to you. |
|
OK White space issues fixed. There are a few else where esp. json files. But I'll fix those later. The changes in the matrix-sdk-branch, already seem to be merged into the develop branch. So there is nothing to do there. |
This closes #1760.
Signed-off-by: William Wragg wm.wragg@gmail.com