add fancy changelog dialog #1972
Conversation
|
Can one of the admins verify this patch? |
| @@ -58,7 +58,8 @@ | |||
| "react-gemini-scrollbar": "matrix-org/react-gemini-scrollbar#5e97aef", | |||
| "sanitize-html": "^1.11.1", | |||
| "ua-parser-js": "^0.7.10", | |||
| "url": "^0.11.0" | |||
| "url": "^0.11.0", | |||
| "whatwg-fetch": "^1.0.0" | |||
There was a problem hiding this comment.
hang on, why do we need whatwg-fetch when we already have browser-request?
|
lgtm other than comments. i'm not entirely sure it was worth spidering github for this info; i'd have just linked through to the appropriate changelog pages, but happy to keep it now it exists ;) |
|
i'd really rather that we didn't sprout two HTTP clients in vector-web/matrix-react-sdk; please either convert browser-request to whatwg-fetch or vice versa, before the proliferation gets worse. |
aviraldg
force-pushed
the
feature-changelog
branch
from
145d2da to
b87f195
Compare
|
@aviraldg please can you get rid of the inline styles? and then this is good to go. |
aviraldg
force-pushed
the
feature-changelog
branch
from
b87f195 to
56813eb
Compare
|
lgtm |
|
Given react-sdk uses whatwg-fetch, courtesy of matrix-org/matrix-react-sdk#296, as do some of its dependencies, I think the horse has already bolted on having two HTTP clients. But still, I'd rather see browser-request than whatwg here. |
No description provided.