Wmwragg/chat message presentation #1987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…u button no longer an input item
…ton, and give a margin to the right of the image
…tf, so sizing is the same across all browsers
…g, and missing avatar for continuation messages after a /me or action message
…ssed as a continuation, but is an info message
… top line in a new message
|
Can one of the admins verify this patch? |
|
The actions have the avatar outset, as as we aren't doing the full user lozenge yet we needed to differentiate these from normal continuation messages with an emoji at the beginning, as the emoji will be the same size as the avatar now
|
…s the size for RTE as well as normal composer
|
Focusing on the design implementation rather than the code right now whilst playing with it, this is almost perfect - thanks! The only two remaining things I've spotted are shown below:
I suspect these can both be fixed by lowering the Avatar (which in turn would reduce the vertical gap?) |
|
codewise this lgtm :) |
… between initial messages and the previous one
|
@ara4n OK, I've tweaked the positions: and reduced the distance between initial message and the previous one |
|
lgtm - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close #1748. A companion branch matrix-org/matrix-react-sdk:wmwragg/chat-message-presentation also needs to be merged.
Signed-off-by: William Wragg wm.wragg@gmail.com