Wmwragg/direct chat sublist #2028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto a sound state, so the states can then change correctly from then on
…ng/unmuting etc. events from room tile up to sub list
…g when people read the outstanding notifications
…menu) is now tinted same colour as the section headers
…n they are stuck together
… on bottom stickies overscroll on matthews machine
…f hidden stuck headers should now work
…llbar and avatar menu
|
Can one of the admins verify this patch? |
|
|
||
| // turn this on for drop & drag console debugging galore | ||
| var debug = false; | ||
|
|
||
| const TRUNCATE_AT = 6; |
There was a problem hiding this comment.
as per chat, suggest 10 rather than 6 in the absence of any "size to fit the available window height" logic
|
LGTM - this is lovely :D |
|
@matrixbot ok to test |
|
Looking at the failed checks, doesn't look like anything I've done. I ran them before I merged up from develop, should have run them after as well. Not sure how to fix |
|
It's failing on my machine as well |
|
for whatever reason the failed tests are on my branch, not yours. i don't know why it built the wrong branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close #1884 . A companion branch matrix-org/matrix-react-sdk:wmwragg/direct-chat-sublist also needs to be merged.
Signed-off-by: William Wragg wm.wragg@gmail.com