Use webpack to copy olm.js #2514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than copying olm.js ourselves in package.json, get webpack to do it for us by declaring it as a second entry point.
|
What does this gain us over copying it manually? Should be be doing the same for emojione? |
|
It gains us the ability to use a cache-buster, which I'll put in a different PR. There's probably an argument for doing the same for emojione, as well as the fonts and other images... but I'd rather cross those bridges another day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than copying olm.js ourselves in package.json, get webpack to do it for
us by declaring it as a second entry point.