Move 'new version' support into Platform #2532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dbkr
commented
Nov 2, 2016
dbkr
commented
- Allow platforms to specify release notes
- Make web update checking much, much simpler (ie. not manually using XMLHTTPRequest)
richvdh
reviewed
Nov 2, 2016
| onFinished: (update) => { | ||
| if(update) { | ||
| window.location.reload(); | ||
| if (props.releaseNotes) { |
There was a problem hiding this comment.
nit: I feel like this should be two separate functions
There was a problem hiding this comment.
still think this needs splitting
|
Oh, found it: matrix-org/matrix-react-sdk#532 |
For template methods that are only used from within vector (ie. new version support)
richvdh
requested changes
Nov 2, 2016
| onFinished: (update) => { | ||
| if(update) { | ||
| window.location.reload(); | ||
| if (props.releaseNotes) { |
There was a problem hiding this comment.
still think this needs splitting
| Modal.createDialog(ChangelogDialog, { | ||
| version: props.version, | ||
| newVersion: props.newVersion, | ||
| releaseNotes: releaseNotes, |
There was a problem hiding this comment.
releaseNotes seems to be undefined here.
| if (checkVersion(props.version) && checkVersion(props.newVersion)) { | ||
| changelog_button = <button className="mx_MatrixToolbar_action" onClick={onChangelogClicked}>Changelog</button>; | ||
| let action_button; | ||
| if (props.releaseNotes || (checkVersion(props.version) && checkVersion(props.newVersion))) { |
There was a problem hiding this comment.
I could do with a comment here explaining that we show a questiondialog if we have releasenotes, or a changelogdialog if we don't.
and change the class to use React createClass syntax while I'm at it, rather than a completely different third style we use nowhere else in the project.
|
ptal |
richvdh
reviewed
Nov 3, 2016
| releaseNotes: React.PropTypes.string, | ||
| }, | ||
|
|
||
| onChangelogClicked: function() { |
There was a problem hiding this comment.
better but why not just bind displayReleaseNotes or displayChangelog to the button in render instead, since you're already doing the conditions there?
rather than deciding in onChangelogClicked
richvdh
approved these changes
Nov 3, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.