-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Electron app (take 3) #2535
Electron app (take 3) #2535
Conversation
From #2511 but with just the actual electron changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks plausible, without not knowing anything about electron. Would like to have another look once the other PRs land
// @flow | ||
|
||
/* | ||
Copyright 2016 Aviral Dasgupta and OpenMarket Ltd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better fix this as Matthew says
} | ||
]; | ||
|
||
if (process.platform === 'darwin') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why only darwin?
let Platform = WebPlatform; | ||
let Platform = null; | ||
|
||
if (window && window.process && window.process && window.process.type === 'renderer') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we make this happen at build time (and make the Web/ElectronPlatform import conditional) so as to avoid shipping electron in the web bundle (assuming that's what happens)?
ok - other PRs now landed, so ptal :) |
(lgtm-ed out-of-band) |
Replaces #2511
This is just the changes to actually make the electron app (minus supporting things like factoring various functionality out to Platform classes).