-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
std::string_view API on file #24
Comments
Would be great to have an |
Still relevant. Not sure what changed on my end, but the above syntax suddenly is giving me incomplete reads. A file of 681 bytes is parsed only up to 181 bytes. I'll mess around and will probably find a way to get the whole thing, but it would be great if CMRC provides a trivial interface for getting the data in an idiomatic way. Having to mess with |
I'll probably resort to this: std::vector<char> data(file.begin(), file.end()); which so far seems to yield correct results. |
I just create a pull request to support using string_view as key to open and find resource. |
Please provide one.
My current workaround is:
std::string_view data(file.begin(), file.end() - file.begin());
The text was updated successfully, but these errors were encountered: