Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use disk buffers when passing through an API key from datadog_agent -> datadog_logs #10139

Closed
jszwedko opened this issue Nov 22, 2021 · 0 comments · Fixed by #18816
Closed
Labels
domain: buffers Anything related to Vector's memory/disk buffers provider: datadog Anything `datadog` service provider related type: bug A code related bug.

Comments

@jszwedko
Copy link
Member

Related: #7065

In #7394 we added support for storing the API key the Datadog Agent sent events with in the datadog_agent source. This enables re-using the same API key in the datadog_logs source to let Vector be a sort of proxy for the Datadog Agent.

However, when disk buffers are used, the metadata is not persisted and so the API key is lost and thus breaks this proxy behavior.

One consideration is that this will result in sensitive data being written to disk. We could consider allowing some sort of encryption of this field.

@jszwedko jszwedko added type: bug A code related bug. domain: buffers Anything related to Vector's memory/disk buffers provider: datadog Anything `datadog` service provider related labels Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: buffers Anything related to Vector's memory/disk buffers provider: datadog Anything `datadog` service provider related type: bug A code related bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant