Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade metrics and metrics-util crates #13625

Closed
Tracked by #11995
bruceg opened this issue Jul 19, 2022 · 0 comments · Fixed by #13653
Closed
Tracked by #11995

Upgrade metrics and metrics-util crates #13625

bruceg opened this issue Jul 19, 2022 · 0 comments · Fixed by #13653
Assignees
Labels
domain: metrics Anything related to Vector's metrics events domain: observability Anything related to monitoring/observing Vector type: tech debt A code change that does not add user value.

Comments

@bruceg
Copy link
Member

bruceg commented Jul 19, 2022

Upgrade metrics >= 0.18 and metrics-util >= 0.12 crates to bring in support for metric handles and a more customizable Registry

This is required due to the introduction of "metric handles" and the more flexible Registry/Storage primitives, which will allow us to interact with the metric values such that we can mutate them rather than simply observe them.

One main thing we'll want to pay attention to is the change, if any, in performance. The changes in metrics-0.18.x were designed to be primarily beneficial to static metric keys, and those who could utilize metric handles directly, both of which we currently do not and cannot do.

This would likely mean some potential performance regressions in areas where we emit many metrics, or emit metrics tied to the rate of events flowing through the topology or specific component.

We've handled these types of issues before by doing local aggregation or some other change to reduce the impact, but this would be at a high level across all metrics that we currently emit, so we'd want to pay attention to changes i.e. as surfaced by soak tests, etc.

@bruceg bruceg changed the title Upgrade metrics and metrics-util crates to bring in support for metric handles and a more customizable Registry Upgrade metrics and metrics-util crates Jul 19, 2022
@bruceg bruceg self-assigned this Jul 19, 2022
@bruceg bruceg added type: tech debt A code change that does not add user value. domain: metrics Anything related to Vector's metrics events domain: observability Anything related to monitoring/observing Vector labels Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: metrics Anything related to Vector's metrics events domain: observability Anything related to monitoring/observing Vector type: tech debt A code change that does not add user value.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant