Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to expire internal metrics by tracking recency #13865

Closed
Tracked by #11995
bruceg opened this issue Aug 5, 2022 · 0 comments · Fixed by #13872
Closed
Tracked by #11995

Add option to expire internal metrics by tracking recency #13865

bruceg opened this issue Aug 5, 2022 · 0 comments · Fixed by #13872
Assignees
Labels
domain: observability Anything related to monitoring/observing Vector domain: performance Anything related to Vector's performance source: internal_metrics Anything `internal_metrics` source related type: enhancement A value-adding code change that enhances its existing functionality.

Comments

@bruceg
Copy link
Member

bruceg commented Aug 5, 2022

Recency provides the metric storage wrapper and logic to detect metrics that have truly not been updated within a given time period. This is required because gauges could technically be the same value when observed at two different times, even if it was in fact changed in between those two observations. Recency deals with this by tracking a "generation" for a metric, such that any operation on the metric at all increments an internal counter -- the generation -- so that you can tell, for both of those two hypothetical observations mentioned above: "oh, the generation is identical, so it hasn't been updated" or "oh, the generations are different, so it's definitely still being updated".

@bruceg bruceg self-assigned this Aug 5, 2022
@bruceg bruceg added type: enhancement A value-adding code change that enhances its existing functionality. domain: observability Anything related to monitoring/observing Vector domain: performance Anything related to Vector's performance source: internal_metrics Anything `internal_metrics` source related labels Aug 5, 2022
@bruceg bruceg changed the title Bolt on the Recency module (part of metrics-util) so that we can begin tracking the generation of each metric Add option to expire internal metrics by tracking recency Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: observability Anything related to monitoring/observing Vector domain: performance Anything related to Vector's performance source: internal_metrics Anything `internal_metrics` source related type: enhancement A value-adding code change that enhances its existing functionality.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant