Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throttle config option to disable "key" label in events_discarded_total metric #17778

Closed
Hexta opened this issue Jun 28, 2023 · 1 comment · Fixed by #19083
Closed

Throttle config option to disable "key" label in events_discarded_total metric #17778

Hexta opened this issue Jun 28, 2023 · 1 comment · Fixed by #19083
Labels
domain: observability Anything related to monitoring/observing Vector type: feature A value-adding code addition that introduce new functionality.

Comments

@Hexta
Copy link
Contributor

Hexta commented Jun 28, 2023

A note for the community

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Use Cases

Currently, throttle exposes every bucket as a key label in events_discarded_total metric:

events_discarded_total{key="value1"} 
events_discarded_total{key="value2"} 
...
events_discarded_total{key="valueN"} 

Using key_field with an unrestricted range of values (-Inf, +Inf) leads in cardinality explosion.

Attempted Solutions

filter and tag_cardinality_limity transforms could help reduce cardinality at the output.
However, utilisation of these transforms will continue to increase proportionately to internal metrics cardinality.

Proposal

Implement a configuration option for throttle transform to disable key label in the metrics.

References

No response

Version

0.30.0

@Hexta Hexta added the type: feature A value-adding code addition that introduce new functionality. label Jun 28, 2023
@dsmith3197 dsmith3197 added the domain: observability Anything related to monitoring/observing Vector label Jun 28, 2023
@dsmith3197
Copy link
Contributor

Note that there have been prior discussions on whether or not to drop the key label altogether here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: observability Anything related to monitoring/observing Vector type: feature A value-adding code addition that introduce new functionality.
Projects
None yet
2 participants