Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade streaming based sinks #2642

Closed
5 tasks
LucioFranco opened this issue May 19, 2020 · 1 comment
Closed
5 tasks

Upgrade streaming based sinks #2642

LucioFranco opened this issue May 19, 2020 · 1 comment
Labels
domain: sinks Anything related to the Vector's sinks sink: kafka Anything `kafka` sink related sink: papertrail Anything `papertrail` sink related sink: pulsar Anything `pulsar` sink related sink: socket Anything `socket` sink related sink: vector Anything `vector` sink related type: tech debt A code change that does not add user value.

Comments

@LucioFranco
Copy link
Contributor

This is a tracking issue to track sinks that don't follow our other service or http based sinks. These sinks are based around the StreamingSink type and do not do any sort of batching.

Sinks to upgrade

  • kafka
  • pulsar
  • socket
  • papertrail
  • vector

Notes

These sinks will be a bit more complicated to upgrade for two reasons 1) currently vector is not using the new Sink api (nor should it) 2) upgrading the libraries might remove the option to use poll based apis.

Suggestions here might be to use the new streaming_sink integrations and working directly with async/await instead of poll. This means the upgrade will be a bit more invasive.

There has been more discussion around this design here. #2122

@LucioFranco LucioFranco added sink: socket Anything `socket` sink related sink: kafka Anything `kafka` sink related sink: vector Anything `vector` sink related domain: sinks Anything related to the Vector's sinks sink: papertrail Anything `papertrail` sink related sink: pulsar Anything `pulsar` sink related labels May 19, 2020
@binarylogic binarylogic added this to the Tech-Debt Payment #1: Move to Tokio 0.2/Futures 0.3 milestone May 30, 2020
@binarylogic binarylogic removed this from the Tech-Debt Payment #1: Move to Tokio 0.2/Futures 0.3 milestone Jul 20, 2020
@binarylogic binarylogic added the type: tech debt A code change that does not add user value. label Aug 17, 2020
@jszwedko
Copy link
Member

jszwedko commented Aug 2, 2022

StreamingSink doesn't appear to exist anymore.

@jszwedko jszwedko closed this as completed Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: sinks Anything related to the Vector's sinks sink: kafka Anything `kafka` sink related sink: papertrail Anything `papertrail` sink related sink: pulsar Anything `pulsar` sink related sink: socket Anything `socket` sink related sink: vector Anything `vector` sink related type: tech debt A code change that does not add user value.
Projects
None yet
Development

No branches or pull requests

4 participants