Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building a package with failed lisp import exits successfully #331

Open
lukash opened this issue Oct 28, 2023 · 0 comments
Open

Building a package with failed lisp import exits successfully #331

lukash opened this issue Oct 28, 2023 · 0 comments

Comments

@lukash
Copy link
Contributor

lukash commented Oct 28, 2023

Having a non-existent import in a package lisp file like so:

(import "funky-import" funky)

Calling vesc_tool --buildPkg prints an error, but passes successfully (returning a 0 exit code). It should fail with a non-zero exit code instead.

Sample output from the current build system of the Float package:

...
vesc-tool --buildPkg "float.vescpkg:float.lisp:ui.qml:0:README-pkg.md:Float"
"Append Imports" : "Line: 1: Imported file not found: /home/lu/dev/vesc_pkg-float/float/funky-import. If you are importing from a package in the git repository you might need to update the package archive. That can be done from the the VESC Packages page."
Read lisp script done
Read qml script done
Package Saved!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant