-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use potentiometer for angle offset calib #380
Open
saitenntaisei
wants to merge
4
commits into
vedderb:master
Choose a base branch
from
sbgisen:feature/use-potentiometer-for-angle-offset-calib
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Use potentiometer for angle offset calib #380
saitenntaisei
wants to merge
4
commits into
vedderb:master
from
sbgisen:feature/use-potentiometer-for-angle-offset-calib
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
saitenntaisei
changed the title
Feature/use potentiometer for angle offset calib
Use potentiometer for angle offset calib
Sep 4, 2024
I have read the CLA Document and I hereby sign the CLA |
saitenntaisei
force-pushed
the
feature/use-potentiometer-for-angle-offset-calib
branch
from
September 4, 2024 06:22
59ca2b8
to
6d84864
Compare
saitenntaisei
force-pushed
the
feature/use-potentiometer-for-angle-offset-calib
branch
from
September 4, 2024 06:49
607984b
to
79ca4e7
Compare
saitenntaisei
pushed a commit
to sbgisen/vesc_tool
that referenced
this pull request
Sep 4, 2024
…tiometer-for-angle-offset-calib
saitenntaisei
force-pushed
the
feature/use-potentiometer-for-angle-offset-calib
branch
from
September 4, 2024 06:54
79ca4e7
to
d00c7b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR is related to vedderb/bldc#760
Detail
I added "Use Potentiometer for Offset Angle Calibration" column in order to toggle feature.
P.S.
this PR also contain Qt 5.12.8 support.