Skip to content

Commit

Permalink
Travis CI: don't pass -l to dump
Browse files Browse the repository at this point in the history
The help text for pokedex dump -l says

    -l LANGS, --langs LANGS
                        comma-separated list of language codes to load,
                        'none', or 'all' (default: en)

However, the values 'none' and 'all' don't work (they are treated as
language names) and the default is to dump all languages, not just
English.

So `dump -l all` actually dumps no text at all because there is no
language called 'all'.

This is about to cause trouble for Travis CI because the next commit
will start checking that load/dump successfully round-trips... which
definitely isn't the case right now because the dump is missing
all text from translated tables.

The dump command and its documentation should definitely be fixed at
some point, but for now just stop using -l.
  • Loading branch information
magical committed Mar 5, 2020
1 parent a166502 commit 77e3d9d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@ install: pip install -e .
before_script: pokedex setup -v
script:
- py.test
- pokedex dump -l all
- pokedex dump

0 comments on commit 77e3d9d

Please sign in to comment.