Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: remove vega-scale dependency #6152

Merged
merged 4 commits into from
Mar 25, 2020
Merged

perf: remove vega-scale dependency #6152

merged 4 commits into from
Mar 25, 2020

Conversation

kanitw
Copy link
Member

@kanitw kanitw commented Mar 25, 2020

This reduces minified file size from 325kb to 264kb

This reduces minified file size from 325kb to 264kb
@kanitw kanitw requested review from domoritz and donghaoren March 25, 2020 17:31
src/config.ts Outdated
'#f58518',
'#e45756',
'#72b7b2',
'#54a24b…eeca3b',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks wrong, no?

@@ -311,7 +310,17 @@ export const defaultConfig: Config = {
concat: {spacing: DEFAULT_SPACING}
};

const tab10 = scheme('tableau10');
const tab10 = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment where this comes from.

@domoritz domoritz merged commit 07a20d0 into master Mar 25, 2020
@domoritz domoritz deleted the kw/vega-scale branch March 25, 2020 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants