Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove string coercion for valid text for text marks #6165

Merged
merged 2 commits into from
Mar 26, 2020
Merged

Conversation

domoritz
Copy link
Member

@domoritz domoritz commented Mar 26, 2020

To support multiline text.

Fixes #6164

@domoritz domoritz closed this Mar 26, 2020
@domoritz domoritz reopened this Mar 26, 2020
@domoritz domoritz changed the title fix: remove string coercion for text marks to support multiline text fix: remove string coercion for valid text for text marks Mar 26, 2020
@domoritz domoritz removed the WIP 🚧 label Mar 26, 2020
@domoritz domoritz requested a review from kanitw March 26, 2020 17:58
@kanitw kanitw merged commit d0517f0 into master Mar 26, 2020
@kanitw kanitw deleted the dom/string branch March 26, 2020 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Array of strings in dataset does not appear as multiline text
2 participants