Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly apply stacked to bar with quantitative x and quantitative y axes #8838

Merged
merged 6 commits into from
Apr 14, 2023

Conversation

kanitw
Copy link
Member

@kanitw kanitw commented Apr 14, 2023

Our default stack logic didn't read orient(ation). This PR fixes that.

@kanitw kanitw changed the title docs(example): stacking QxQ bars fix: correctly apply stacked to bar with quantitative x and quantitative y axes Apr 14, 2023
@kanitw kanitw marked this pull request as draft April 14, 2023 16:41
@kanitw kanitw marked this pull request as ready for review April 14, 2023 16:45
Copy link
Contributor

@fandu-db fandu-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Ham!

@kanitw kanitw merged commit 4b9d22c into main Apr 14, 2023
@kanitw kanitw deleted the kw/stacking-qq-bar branch April 14, 2023 21:41
BradyJ27 pushed a commit to BradyJ27/vega-lite that referenced this pull request Oct 19, 2023
…ive y axes (vega#8838)

Co-authored-by: GitHub Actions Bot <vega-actions-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants