Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow custom tooltip formatting #8883

Merged
merged 19 commits into from
May 5, 2023
Merged

Conversation

lsh
Copy link
Member

@lsh lsh commented May 4, 2023

Please:

  • [-] Make the pull requests (PRs) atomic (fix one issue at a time). Multiple relevant issues that must be fixed together? Make atomic commits so we can easily review each issue.
  • [-] Provide a concise title as a semantic commit message (e.g. "fix: correctly handle undefined properties") so we can easily copy it to the release note.
    • Use imperative mood and present tense.
  • Mention relevant issues in the description (e.g., Fixes #1 / Fixes part of #1).
  • [-] Lint and test (Run yarn test).
  • [-] Review your changes before sending the PR (to ensure code quality).
  • For new features:
    • [-] Add new unit tests.
    • [-] Update the documentation under site/docs/ + add examples.

Tips:

@lsh lsh requested a review from kanitw May 4, 2023 22:33
Copy link
Member

@kanitw kanitw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

  • good to add an example spec to show that this feature work (in examples/specs)
  • refer to the example in config.md

site/docs/config.md Outdated Show resolved Hide resolved
src/config.ts Outdated Show resolved Hide resolved
src/config.ts Outdated Show resolved Hide resolved
Copy link
Member

@kanitw kanitw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix minor nit before merging. :)

src/compile/mark/encode/tooltip.ts Outdated Show resolved Hide resolved
site/docs/config.md Show resolved Hide resolved
Copy link
Member

@kanitw kanitw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change axis format to no decimal points and we merge squash merge :)

@kanitw kanitw enabled auto-merge (squash) May 5, 2023 22:42
@kanitw kanitw merged commit e7b45b8 into main May 5, 2023
@kanitw kanitw deleted the lsh/tooltip-formatter-config branch May 5, 2023 22:48
BradyJ27 pushed a commit to BradyJ27/vega-lite that referenced this pull request Oct 19, 2023
Co-authored-by: GitHub Actions Bot <vega-actions-bot@users.noreply.github.com>
Co-authored-by: Kanit Wongsuphasawat <kanitw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants