Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add extent transform #8940

Merged
merged 19 commits into from
Jun 20, 2023
Merged

feat: add extent transform #8940

merged 19 commits into from
Jun 20, 2023

Conversation

lsh
Copy link
Member

@lsh lsh commented Jun 9, 2023

Adds an interface to use Vega's extent transform.

@lsh lsh requested a review from domoritz June 9, 2023 21:46
@lsh lsh requested review from yhoonkim and kanitw June 9, 2023 22:44
Copy link
Member

@domoritz domoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'd like to have a quick check from @kanitw before merging.

site/docs/transform/extent.md Outdated Show resolved Hide resolved
src/compile/data/extent.ts Show resolved Hide resolved
src/transform.ts Outdated Show resolved Hide resolved
src/compile/data/extent.ts Outdated Show resolved Hide resolved
@lsh lsh merged commit 85e5cc8 into main Jun 20, 2023
19 checks passed
@lsh lsh deleted the lsh/extent-transform branch June 20, 2023 21:43
BradyJ27 pushed a commit to BradyJ27/vega-lite that referenced this pull request Oct 19, 2023
* feat: add `extent` transform

* chore: add quotes around word transform

* chore: add test cases

* chore: add extent.ts

* chore: update schema [CI]

* chore: update examples [CI]

* fix: handle density case

* chore: update examples [CI]

* Update site/docs/transform/extent.md

Co-authored-by: Dominik Moritz <domoritz@gmail.com>

* Update src/compile/data/extent.ts

Co-authored-by: Dominik Moritz <domoritz@gmail.com>

* chore: make `param` field required rather than optional

* chore: update schema [CI]

* chore: update examples [CI]

* chore: add to toc

* chore: update TOC [CI]

* chore: update doc text

* fix: extent produced fields should be the empty set

---------

Co-authored-by: GitHub Actions Bot <vega-actions-bot@users.noreply.github.com>
Co-authored-by: Dominik Moritz <domoritz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants