Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make bin/timeUnit band respect minBandSize config #8958

Merged
merged 5 commits into from
Jun 21, 2023

Conversation

kanitw
Copy link
Member

@kanitw kanitw commented Jun 20, 2023

fix #8957

@kanitw kanitw force-pushed the kw/8957-minBandSize-timeUnit branch from 4d06cba to 0597d61 Compare June 21, 2023 18:27
@kanitw kanitw changed the title doc(example): add problematic example fix: respect minBandSize for bin/timeUnit band Jun 21, 2023
@kanitw kanitw requested review from fandu-db and domoritz June 21, 2023 18:38
@kanitw kanitw force-pushed the kw/8957-minBandSize-timeUnit branch from 5aa8a1b to 0da1160 Compare June 21, 2023 18:46
@kanitw kanitw force-pushed the kw/8957-minBandSize-timeUnit branch from d834d06 to 06f1e7b Compare June 21, 2023 19:00
@kanitw kanitw marked this pull request as ready for review June 21, 2023 19:10
@kanitw kanitw changed the title fix: respect minBandSize for bin/timeUnit band fix: make bin/timeUnit band respect minBandSize config Jun 21, 2023
@kanitw kanitw merged commit d1c012e into main Jun 21, 2023
7 checks passed
@kanitw kanitw deleted the kw/8957-minBandSize-timeUnit branch June 21, 2023 19:10
BradyJ27 pushed a commit to BradyJ27/vega-lite that referenced this pull request Oct 19, 2023
Co-authored-by: GitHub Actions Bot <vega-actions-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Respect minBandSize for timeUnit band
2 participants