fix: show gridline of first axis only for dual axes charts #8962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domoritz
approved these changes
Jun 26, 2023
src/compile/axis/parse.ts
Outdated
| if (resolve.axis[channel] === 'independent' && axes[channel] && axes[channel].length > 1) { | ||
| let first = true; | ||
| for (const axisCmpt of axes[channel]) { |
There was a problem hiding this comment.
With .entries(), you get the index and can use that instead of the somewhat ugly first variable.
|
Good change overall (as discussed on our hike). |
BradyJ27
pushed a commit
to BradyJ27/vega-lite
that referenced
this pull request
Oct 19, 2023
Co-authored-by: GitHub Actions Bot <vega-actions-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale: Better transitions -- at least adding the second axis won't suddenly hide all gridlines