-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Extent" property for Regression does not modify the regression extent and nullifies the regression. #9230
Comments
Someone else is also having this issue from SO: https://stackoverflow.com/questions/77845962/regression-line-issue-in-vegalite-charts |
When adding this to Vega-Lite: "transform": [
{"regression": "IMDB Rating", "on": "Rotten Tomatoes Rating", "extent": [0, 100]}
], The generated Vega ends up with this transform: {
"name": "data_1",
"source": "source_0",
"transform": [{"type": "extent", "field": [0, 100]}]
}, This is nonsensical, as @vega/maintainers Does anyone have context on how this is supposed to work in terms of the generated Vega? It seems to me like this needs to be a configuration option in the Vega transform, and it's not clear to me how this ever worked. |
FWIW, I filed the issue on I was certain that this used to work and it seems that with Looking at the release notes for 5.1.0 (https://github.com/altair-viz/altair/releases/tag/v5.1.0) this corresponds to the Comparing both I think I'm unable to pinpoint this further, but maybe this insight helps someone else :) |
I can confirm that when I test with:
and vary the vega-lite version, then This brings the relevant changeset down to: v5.9.3...v5.10.0 Edit: After digging a little, the only relevant change is "feat: add extent transform (#8940)" Some of the tests look an awful lot like the bug happening here.
I think this might be a simple naming collision. The code for dealing with the |
I see the issue. Will put up a fix ASAP. |
I initially posted this in Vega and was suggested to move to here.
When I try to add the "extent" property as listed in the vega-lite documentation, the regression no longer exists and instead the data becomes a line chart.
This is the example pulled from the regression example in the vega-lite documentation:
However, when I add in the extent property to the example, this is the result:
The text was updated successfully, but these errors were encountered: