Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly place unfiltered null values for line (#9326) #9334

Merged
merged 5 commits into from
May 2, 2024

Conversation

kanitw
Copy link
Member

@kanitw kanitw commented May 2, 2024

PR Description

Previously we forgot to add conditional logic for invalid values when filtering is disabled (mark.invalid = null)

Interestingly, given area applies stack layout by default, it doesn't suffer from the same bug that line does.

@kanitw kanitw requested a review from a team as a code owner May 2, 2024 15:51
GitHub Actions Bot and others added 3 commits May 2, 2024 15:51
Previously we forgot to add conditional logic for invalid values when filtering is disabled (mark.invalid = null)
@kanitw kanitw changed the title fix: correctly place unfiltered null values for line/area (#9326) fix: correctly place unfiltered null values for line (#9326) May 2, 2024
@kanitw kanitw requested a review from lsh May 2, 2024 16:00
@vega vega deleted a comment from cloudflare-workers-and-pages bot May 2, 2024
Copy link
Member

@lsh lsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since given new examples and lack of diffs generated.

@kanitw
Copy link
Member Author

kanitw commented May 2, 2024

given new examples and lack of diffs generated.

to be clear, the new example shows the right fix:

image

@kanitw kanitw merged commit b617c84 into main May 2, 2024
11 checks passed
@kanitw kanitw deleted the kw/9326-line-invalid-null branch May 2, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants