Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#9343): binned stacked area now correctly filter null values #9344

Merged
merged 4 commits into from
May 9, 2024

Conversation

kanitw
Copy link
Member

@kanitw kanitw commented May 8, 2024

binned stacked area now correctly filter null values

See the example fixed in the 4th commit.

@kanitw kanitw requested a review from a team as a code owner May 8, 2024 16:35
Copy link

cloudflare-workers-and-pages bot commented May 8, 2024

Deploying vega-lite with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9e827ec
Status:🚫  Build failed.

View logs

@kanitw kanitw requested review from domoritz and lsh May 8, 2024 16:40
@kanitw kanitw force-pushed the kw/9343-stacked-area-binned branch from 24fee36 to 2c42b32 Compare May 8, 2024 23:12
@kanitw kanitw force-pushed the kw/9343-stacked-area-binned branch from 2c42b32 to 9e827ec Compare May 8, 2024 23:35
Copy link
Contributor

@yhoonkim yhoonkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kanitw kanitw merged commit 7cd3829 into main May 9, 2024
10 checks passed
@kanitw kanitw deleted the kw/9343-stacked-area-binned branch May 9, 2024 18:29
@domoritz
Copy link
Member

domoritz commented May 9, 2024

Nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants